-
Notifications
You must be signed in to change notification settings - Fork 103
feat: PASV Port mapping #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 86.80% 86.92% +0.11%
==========================================
Files 12 12
Lines 2350 2356 +6
==========================================
+ Hits 2040 2048 +8
+ Misses 235 232 -3
- Partials 75 76 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like
Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Local IP Availability Test Flaw
The TestPASVIPMatch
test's 127.0.1.1
availability check is flawed. It attempts to dial from 127.0.1.1
to 127.0.0.1:22
(SSH). This can cause the test to be unnecessarily skipped if port 22 is closed, SSH is not running, or a firewall blocks the connection, even if 127.0.1.1
is properly configured and available for local binding.
transfer_test.go#L1100-L1103
Lines 1100 to 1103 in eaa9484
testAddr := &net.TCPAddr{IP: net.ParseIP("127.0.1.1"), Port: 0} | |
if _, err := net.DialTCP("tcp", testAddr, &net.TCPAddr{IP: net.ParseIP("127.0.0.1"), Port: 22}); err != nil { | |
t.Skip("Skipping test: 127.0.1.1 not available. Run 'sudo ifconfig lo0 alias 127.0.1.1 up' to enable this test.") | |
} |
Was this report helpful? Give feedback by reacting with 👍 or 👎
No description provided.